fix: send MCP initialize metadata for stdio backends #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the MCP initialization process for stdio backends by adding required protocol metadata and timeout handling. The change ensures proper client identification during the initialization handshake.
- Adds protocol version and client info to the initialization request
- Implements a bounded timeout context to prevent indefinite hangs during initialization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ProtocolVersion: mcp.LATEST_PROTOCOL_VERSION, | ||
| ClientInfo: mcp.Implementation{ | ||
| Name: "mcp-auth-proxy", | ||
| Version: "dev", |
There was a problem hiding this comment.
Hardcoded version string 'dev' should be replaced with an actual version variable or constant that can be updated during build time (e.g., via ldflags). This makes it easier to track which version of the proxy is being used in production.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure stdio-backed MCP initialization sends protocol version and client info, with a bounded init context to avoid premature exits.
Type of Change
Related Issues