Possible Typo in _includes/footer.html Causing Improper JS Loading #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
The code under
{% if site.extra_footer_js %}incorrectly references{%- for extra_js in site.extra_header_js -%}instead of{%- for extra_js in site.extra_footer_js -%}Caused Result
This issue may prevent the footer scripts from loading, but executing those intended for the header.
Disclaimer (?)
It's my first time to make an open PR or issue... Hopefully it's an real issue and I didn't use an awful format. I'm open to feedback on formatting and approach, and if anything wrong, please forgive me. QAQ