#5769 - Pause all audio attachments if receiving an incoming call. #6055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 664b4abda9b17caf45a56edc38a4a7b5c4134776)
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Keep open
…On Tue, Aug 19, 2025 at 7:27 AM github-actions[bot] < ***@***.***> wrote:
*github-actions[bot]* left a comment (signalapp/Signal-iOS#6055)
<#6055 (comment)>
This PR has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you
for your contributions.
—
Reply to this email directly, view it on GitHub
<#6055 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI3H5DIPJPPL3YESGMGSHED3OMJZVAVCNFSM6AAAAAB5RYWNRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMBQGU2TGMRUGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Description
This PR
fixes #5769by making sure that audio attachments don't interfere with signal calls. This problem stems from audio attachments that are playing while an incoming call happens, have their audio controls captured by NowPlayingInforCenter and RemoteCommandCenter, switch subsequently blocks audio coming from a signal call.I tested this by playing audio attachments and then initiating an incoming call. Additionally, I tested to make sure that audio attachments still interrupt music playing in the background, and subsequently resume upon the audio attachment pausing or completing.