-
Notifications
You must be signed in to change notification settings - Fork 23
ci: Local Net CI Workflow #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-v0.3.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new CI workflow to run a local testnet with Assertoor testing framework in Anchor's continuous integration pipeline. The workflow builds a Docker image and runs local testnet tests to ensure network functionality.
Key changes:
- New GitHub Actions workflow for local testnet testing
- Docker image building and artifact management for the testnet
- Integration with Assertoor testing framework and Kurtosis for network orchestration
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.github/workflows/local-testnet.yml
Outdated
repository: dknopik/ssv-mini | ||
ref: fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a personal repository ('dknopik/ssv-mini') and a non-specific branch reference ('fixes') in production CI creates dependency risks. Consider using a stable, official repository or fork it under the organization's namespace with a specific commit hash or tagged version.
repository: dknopik/ssv-mini | |
ref: fixes | |
repository: your-org/ssv-mini | |
ref: v1.2.3 |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @dknopik
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, at least we should use a specific commit hash here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we using a personal branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dknopik ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to use the specific commit hash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we using a personal branch?
currently, we had to make slight adjustments in order to get the config working. this is currently done in a slightly hacky way to get this MVP for our CI.
We will continue to improve on this initial state and eventually upstream all changes to ssv-mini
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about we move it to sigp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please briefly explain what is being tested in this PR for people not familiar with it (like me)? |
IMO this is good to go, but before merging I want to test intentionally breaking anchor it to see if the CI catches it 😈 will do soon |
I broke block production, but the CI seems to pass anyway. Can you please take a look? |
Where are these tests defined? |
Issue Addressed
Run Testnet in Anchor's CI
Proposed Changes
Added a new CI Workflow to Run Assertoor
Additional Info
New github workflow is to run a local testnet with kurtosis and run a few test with assertoor
The tests are to check: