-
Notifications
You must be signed in to change notification settings - Fork 904
Update Rust Edition to 2024 #7766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like Rust 1.89 is in effect and is already linting the chain I revised all in this single commit: 8665e63, unfortunately this makes the diff and files changed increased by a lot |
This pull request has merge conflicts. Could you please resolve them @chong-he? 🙏 |
I think we should merge this ASAP and include it in @macladson you probably have the best ability to review quickly as you can review just the diff since your last review. @chong-he there is a single conflict now which would be good to fix so we can merge immediately once Mac gives the 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I've gone through all the new changes and it all looks good to me 👍
Nice work @chong-he!
Some of the new &&
chaining reads a bit awkwardly in some places but I think overall the 2024 changes are an upgrade
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You may have to fix your CI before adding the pull request to the queue again. |
Thank you so much for your detailed review! |
Woohoo! Thanks Mac for the review and CK for the impl! ❤️ |
Issue Addressed
Thanks @dknopik and @michaelsproul for your help!