Fix malloc_utils features (sysmalloc) #7770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
changed the title
michaelsproul
commented
Jul 25, 2025
Comment on lines
+47
to
+51
| [target.'cfg(not(target_os = "windows"))'.dependencies] | ||
| malloc_utils = { workspace = true, features = ["jemalloc"] } | ||
|
|
||
| [target.'cfg(target_os = "windows")'.dependencies] | ||
| malloc_utils = { workspace = true, features = [] } |
There was a problem hiding this comment.
These changes ensure that lcli actually uses jemalloc on Linux, which is potentially relevant for the benchmarking subcommands.
|
Some required checks have failed. Could you please take a look @michaelsproul? 🙏 |
mergify
bot
added
waiting-on-author
michaelsproul
added
v8.0.0-rc.0
|
Added |
jimmygchen
approved these changes
Aug 15, 2025
jimmygchen
added
ready-for-merge
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Follow-up to:
The
heaptrackfeature added in my previous PR was ineffective, because the jemalloc feature was turned on by the Linux target-specific dependency.This PR tweaks the features such that:
lighthouse/Cargo.toml), and completely disabled on Windows.sysmallocfeature is set on Linux then it overrides jemalloc when selecting an allocator, even if the jemalloc feature is enabled (and the jemalloc dep was compiled).