Skip to content

Simplify ConfigAndPreset #7777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 25, 2025
Merged

Simplify ConfigAndPreset #7777

merged 6 commits into from
Jul 25, 2025

Conversation

michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Jul 23, 2025 •
edited
Loading

Proposed Changes

I noticed that we are serving preset values for Fulu on mainnet nodes prior to the fork. This has already gone live in v7.1.0, but should hopefully be handled in a graceful way by API consumers.

This PR reverts the serving of Fulu data prior to Fulu, by serving Fulu data only if Fulu is scheduled.

@michaelsproul michaelsproul added HTTP-API backwards-incompat Backwards-incompatible API change das Data Availability Sampling labels Jul 23, 2025
michaelsproul
michaelsproul commented Jul 23, 2025
View reviewed changes
@michaelsproul michaelsproul requested a review from macladson July 23, 2025 04:00
@michaelsproul michaelsproul added the ready-for-review The code is ready for review label Jul 23, 2025
@michaelsproul michaelsproul mentioned this pull request Jul 23, 2025
Merged
jimmygchen
jimmygchen reviewed Jul 24, 2025
View reviewed changes
jimmygchen
jimmygchen reviewed Jul 24, 2025
View reviewed changes
jimmygchen
jimmygchen reviewed Jul 24, 2025
View reviewed changes
jimmygchen
jimmygchen reviewed Jul 24, 2025
View reviewed changes
@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jul 24, 2025
@michaelsproul michaelsproul changed the title Serve ConfigAndPreset for latest_stable fork Simplify ConfigAndPreset Jul 25, 2025
@michaelsproul michaelsproul added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jul 25, 2025
jimmygchen
jimmygchen approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 25, 2025
mergify bot added a commit that referenced this pull request Jul 25, 2025
@mergify
Merge of #7777
8d879f5
@mergify mergify bot mentioned this pull request Jul 25, 2025
Closed
6 tasks
mergify bot added a commit that referenced this pull request Jul 25, 2025
@mergify
Merge of #7777
b2db035
@mergify mergify bot mentioned this pull request Jul 25, 2025
Closed
6 tasks
mergify bot added a commit that referenced this pull request Jul 25, 2025
@mergify
Merge of #7777
bb8aca9
@mergify mergify bot mentioned this pull request Jul 25, 2025
Closed
6 tasks
@mergify Mergify
Copy link

mergify bot commented Jul 25, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #7797.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify bot added a commit that referenced this pull request Jul 25, 2025
@mergify
Merge of #7777
25c1fb2
@mergify mergify bot mentioned this pull request Jul 25, 2025
Closed
6 tasks
@mergify mergify bot merged commit 134039d into sigp:unstable Jul 25, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

@macladson macladson Awaiting requested review from macladson

Assignees
No one assigned
Labels
backwards-incompat Backwards-incompatible API change das Data Availability Sampling HTTP-API ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelsproul @jimmygchen