Bump Rust version to 1.88 #7787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
added
ready-for-review
|
Updating self-hosted runners to 1.88, will re-run CI once that's done. |
|
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
mergify
bot
added
waiting-on-author
| @@ -4,7 +4,7 @@ version = "7.1.0" | |||
| authors = ["Sigma Prime <[email protected]>"] | |||
| edition = { workspace = true } | |||
| autotests = false | |||
| rust-version = "1.87.0" | |||
| rust-version = "1.88.0" | |||
There was a problem hiding this comment.
We don't technically need to bump the MSRV, right?
There was a problem hiding this comment.
We don't, but the previous PR bumped the dockerfile to 1.88, and we usually bump all the versions together - a bit easier to maintain IMO.
OR we could keep everything at 1.87, what do you think?
michaelsproul
added
ready-for-merge
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
In #7743, rust version was bumped:
Dockerfileto 1.88We also need to bump the other docker images as well, and might as well keep them all consistent at 1.88.