Skip to content

Conversation

anshalshukla
Copy link

Issue Addressed

Issue #7966

Proposed Changes

Changes logging level to Warn from Error.

@anshalshukla anshalshukla requested a review from jxs as a code owner September 3, 2025 06:07
Copy link

cla-assistant bot commented Sep 3, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Sep 3, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@eserilev
Copy link
Member

eserilev commented Sep 4, 2025

hm I dont think downgrading to warn is what I had in mind. I think in the case where backfill is paused due to insufficient peers we can just log a single message. This is a bit more involved that just changing the log level. We want to be able to catch the specific error variant InsufficientPeers and log it accordingly. We also at the moment log a message for each column we have insufficient peers for, it would be better to just log one message.

@jimmygchen jimmygchen added the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-author The reviewer has suggested changes and awaits thier implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants