add user agent in http requests #7990
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eserilev
requested changes
Sep 3, 2025
|
Right, I don’t actually need those. They were left over from something else I was experimenting with and went unnoticed. |
eserilev
requested changes
Sep 4, 2025
| #[cfg(test)] | ||
| mod tests { | ||
| use super::*; | ||
| use mockito::{Matcher, Server}; |
There was a problem hiding this comment.
This probably won't compile now.
We still want to write a test to check that a user agent is returned, we have some examples of api tests in our repo that you can reference.
You can run our test suite via make test
There was a problem hiding this comment.
I'll update the PR in a couple of days.
jimmygchen
added
the
waiting-on-author
anshalshukla
force-pushed
the
add-user-agent
branch
2 times, most recently
from
e4be8bc to
9e3a12d
Compare
anshalshukla
force-pushed
the
add-user-agent
branch
from
9e3a12d to
6eedf27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Issue #7963
Proposed Changes
lighthouse_versioncrate