Grab newer version of leveldb-sys #8004
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit grabs a version of leveldb-sys that: - Replaces snappy and leveldb with submodules. - Rewrites the CI workflow to be more modern. - Allows linking against the system version of leveldb and snappy by setting `LEVELDB_NO_VENDOR=1`. - Hopefully resolves a linking issue when using the vendored snappy.
|
I think the leveldb crates are basically unmaintained, so we might need our own fork if we want this |
|
Yeah, I saw that your PR fixing paths with spaces has been sitting around for a while. What's your vibe on this? leveldb (minus snappy) isn't too broken as far as you're concerned, so I'd understand your reluctance to add this just for my packaging purposes. |
|
Yeah I think my preference is to continue building LH against stock LevelDB, just with snappy disabled. Do you want snappy working just for the sake of completeness in packaging? Would it be much of a loss if the package just didn't offer snappy support? |
|
Fixing snappy was just a bonus. I'm only interested in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Patch leveldb-sys with the one from this pull request.
Additional Info
This commit grabs a version of leveldb-sys that:
LEVELDB_NO_VENDOR=1.