Skip to content

Conversation

Galoretka
Copy link

  • Ensure is_infinity reflects the actual aggregate when aggregating onto an empty AggregateSignature.
  • Previously, starting from empty() and aggregating an infinity signature produced an aggregate whose underlying point was infinity but is_infinity stayed false. This broke eth_fast_aggregate_verify for empty pubkeys and desynced the flag from the serialized value.
  • Update add_assign and add_assign_aggregate: when self was empty, set is_infinity = other.is_infinity; otherwise keep the existing conjunction behavior. This aligns with the doc that empty acts as “set to infinity before aggregation” and keeps is_infinity consistent with the bytes.

Copy link

cla-assistant bot commented Sep 9, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
Copy link

cla-assistant bot commented Sep 9, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@michaelsproul michaelsproul added crypto An issue/PR that touches cryptography code. ready-for-review The code is ready for review labels Sep 9, 2025
Copy link

mergify bot commented Sep 9, 2025

Some required checks have failed. Could you please take a look @Galoretka? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto An issue/PR that touches cryptography code. waiting-on-author The reviewer has suggested changes and awaits thier implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants