Skip to content

Conversation

aviggiano
Copy link

Issue Addressed

No issue

Proposed Changes

Use HTTPS for dependency

Additional Info

N/A

Copy link

cla-assistant bot commented Sep 19, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Sep 19, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@michaelsproul
Copy link
Member

Thanks @aviggiano!

Not sure why we were using HTTP, that's a great catch.

Would you mind rebasing your changes on unstable and signing the CLA (see bot comment above mine)? I'll update the target branch, but GH won't pass CI until the branch is actually rebased.

Thanks

@michaelsproul michaelsproul changed the base branch from stable to unstable September 22, 2025 00:42
@michaelsproul michaelsproul changed the title Update Cargo.toml Use HTTPS for xdelta3 in Cargo.toml Sep 22, 2025
@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. dependencies Pull requests that update a dependency file labels Sep 22, 2025
@hopinheimer
Copy link
Member

hopinheimer commented Sep 22, 2025

do you think we should add a CI job to check this just in case?

@michaelsproul
Copy link
Member

Yeah that would be good, there might be an existing cargo addon for this?

@aviggiano
Copy link
Author

yeah I caught this while trying to build lighthouse locally and it failed after I changed something else

I think a CI check would be nice

@michaelsproul michaelsproul added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 22, 2025
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link

mergify bot commented Sep 22, 2025

Some required checks have failed. Could you please take a look @aviggiano? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 22, 2025
@michaelsproul michaelsproul added v8.0.0-rc.0 Q3 2025 release for Fusaka on Holesky and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 22, 2025
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the cargo lock check is failing and the lock file needs an update too.

https://github.com/sigp/lighthouse/actions/runs/17913557528/job/50941650269

@jimmygchen jimmygchen added the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label Sep 23, 2025
@mergify mergify bot added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 24, 2025
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Sep 24, 2025
@mergify mergify bot merged commit d80c0ff into sigp:unstable Sep 24, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge. v8.0.0-rc.0 Q3 2025 release for Fusaka on Holesky
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants