-
Notifications
You must be signed in to change notification settings - Fork 917
Use HTTPS for xdelta3 in Cargo.toml #8094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @aviggiano! Not sure why we were using HTTP, that's a great catch. Would you mind rebasing your changes on Thanks |
do you think we should add a CI job to check this just in case? |
Yeah that would be good, there might be an existing cargo addon for this? |
yeah I caught this while trying to build lighthouse locally and it failed after I changed something else I think a CI check would be nice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Some required checks have failed. Could you please take a look @aviggiano? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the cargo lock check is failing and the lock file needs an update too.
https://github.com/sigp/lighthouse/actions/runs/17913557528/job/50941650269
Issue Addressed
No issue
Proposed Changes
Use HTTPS for dependency
Additional Info
N/A