Skip to content

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 6, 2025

Protected data setting on QA:
Screenshot 2025-08-06 134934

Protected data settings with this PR:
Screenshot 2025-08-06 134851


This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 46.66667% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.24%. Comparing base (e082cf9) to head (91f6bd8).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...omponents/ProjectSettings/ProjectProtectedData.tsx 45.45% 6 Missing ⚠️
Backend/Helper/DuplicateFinder.cs 42.85% 2 Missing and 2 partials ⚠️
Backend/Controllers/MergeController.cs 0.00% 3 Missing ⚠️
Backend/Services/MergeService.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3919      +/-   ##
==========================================
- Coverage   74.28%   74.24%   -0.05%     
==========================================
  Files         292      292              
  Lines       10628    10642      +14     
  Branches     1342     1344       +2     
==========================================
+ Hits         7895     7901       +6     
- Misses       2352     2358       +6     
- Partials      381      383       +2     
Flag Coverage Δ
backend 85.41% <37.50%> (-0.09%) ⬇️
frontend 65.87% <57.14%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec imnasnainaec marked this pull request as ready for review September 12, 2025 18:29
@imnasnainaec imnasnainaec added the 🟨Medium Medium-priority PR label Sep 12, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation test goal labels Sep 12, 2025
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 19 of 19 files at r1, 2 of 2 files at r2, 9 of 9 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit b2e482c into master Oct 13, 2025
19 checks passed
@imnasnainaec imnasnainaec deleted the merge-ignore-protected branch October 13, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend documentation Improvements or additions to documentation enhancement New feature or request frontend goal: MergeDup goal 🟨Medium Medium-priority PR project test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants