Skip to content

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Sep 8, 2025

Also reduce id and data-testid clutter.
Also remove some props that were assigned the default value.

Resolves #3800


This change is Reviewable

Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.08%. Comparing base (a65cb0a) to head (832fd35).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/components/PasswordReset/ResetPage.tsx 0.00% 2 Missing ⚠️
src/components/ProjectSettings/ProjectImport.tsx 0.00% 2 Missing ⚠️
src/components/PasswordReset/Request.tsx 0.00% 1 Missing ⚠️
...oals/CharacterInventory/CharInv/CharacterEntry.tsx 66.66% 1 Missing ⚠️
src/utilities/fontComponents.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3941      +/-   ##
==========================================
- Coverage   74.15%   74.08%   -0.08%     
==========================================
  Files         292      292              
  Lines       10653    10653              
  Branches     1346     1347       +1     
==========================================
- Hits         7900     7892       -8     
- Misses       2369     2376       +7     
- Partials      384      385       +1     
Flag Coverage Δ
backend 85.29% <ø> (ø)
frontend 65.67% <41.66%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec imnasnainaec marked this pull request as ready for review September 11, 2025 20:28
@imnasnainaec imnasnainaec added the 🟩Low Low-priority PR label Sep 11, 2025
@imnasnainaec imnasnainaec changed the title Retire InputLabelProps, InputProps Replace InputLabelProps, InputProps, inputProps with slotProps Sep 11, 2025
@jasonleenaylor
Copy link
Contributor

src/goals/ReviewEntries/ReviewEntriesTable/Cells/EditCell/EditSenseDialog.tsx line 417 at r3 (raw file):

      }
      value={props.gloss.def}
      variant="outlined"

So this is the default now?

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 35 files reviewed, all discussions resolved (waiting on @imnasnainaec)


src/goals/ReviewEntries/ReviewEntriesTable/Cells/EditCell/EditSenseDialog.tsx line 417 at r3 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

So this is the default now?

Yes, the default of the underlying MUI TextField.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 8 of 8 files at r1, 14 of 18 files at r2, 13 of 13 files at r3.
Reviewable status: 34 of 35 files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit c91e376 into master Oct 14, 2025
18 of 19 checks passed
@imnasnainaec imnasnainaec deleted the slot-props branch October 14, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate deprecated props of TextField to slotProps

2 participants