-
-
Notifications
You must be signed in to change notification settings - Fork 9
Add support for new auto-publish and rebuild fields in JSON import #1359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new auto-publish and rebuild fields in JSON import #1359
Conversation
WalkthroughAdds two optional boolean fields ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used🧠 Learnings (3)📚 Learning: 2025-09-22T14:59:53.366ZApplied to files:
📚 Learning: 2025-09-12T14:07:02.200ZApplied to files:
📚 Learning: 2025-09-10T13:51:14.948ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Connected to part 2 of issue #1303 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/lib/projects/index.ts(1 hunks)src/routes/(authenticated)/projects/import/[id=idNumber]/+page.server.ts(1 hunks)
🔇 Additional comments (1)
src/routes/(authenticated)/projects/import/[id=idNumber]/+page.server.ts (1)
221-222: Implementation looks correct; verifyAllowDownloadsis intentionally excluded.The two new fields are properly implemented:
- Both default to
falsewhen not provided in the import JSON (appropriate for opt-in automation features)- Field names match the schema validation in
src/lib/projects/index.tsHowever, note that
AllowDownloads(line 136 in the schema) is accepted during validation but not persisted here. Ensure this is intentional.
This update modifies the following files to include support for new boolean fields (autoPublishAfterRebuild and autoRebuildOnSoftwareUpdate) in the project import process:
src/routes/(authenticated)/projects/import/[id=idNumber]/+page.server.ts
src/lib/projects/index.ts
These changes ensure that importing projects with the new automation settings succeeds without errors and that old field (AutomaticBuilds) is no longer expected.
Summary by CodeRabbit