-
-
Notifications
You must be signed in to change notification settings - Fork 17
Validate usfm versification #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Still need to add tests. |
7ff60f6 to
b8a9089
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #353 +/- ##
==========================================
+ Coverage 72.38% 72.57% +0.19%
==========================================
Files 417 423 +6
Lines 35632 35798 +166
Branches 4929 4949 +20
==========================================
+ Hits 25793 25982 +189
+ Misses 8744 8718 -26
- Partials 1095 1098 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Tests have been added. I'm really excited to get this in 🎉. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddaspit reviewed 16 of 22 files at r1, 2 of 3 files at r2, 7 of 10 files at r3, 3 of 4 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Enkidu93)
src/SIL.Machine/Corpora/UsfmVersificationMismatchDetector.cs line 108 at r4 (raw file):
if ( Type == UsfmVersificationMismatchType.MissingVerseSegment && VerseRef.TryParse(
Why are you using TryParse here and not the constructor?
src/SIL.Machine/Corpora/IParatextProjectFileHandler.cs line 5 at r1 (raw file):
namespace SIL.Machine.Corpora { public interface IParatextProjectFileHandler
Shouldn't we also use this interface in ParatextProjectSettingsParserBase?
src/SIL.Machine/Corpora/ParatextProjectVersificationMismatchDetector.cs line 8 at r1 (raw file):
namespace SIL.Machine.Corpora { public abstract class ParatextProjectVersificationMismatchDetector
By convention, ABCs are suffixed with Base.
src/SIL.Machine/Corpora/ParatextProjectTermsParserBase.cs line 299 at r1 (raw file):
} private Stream Open(string fileName) => _paratextProjectFileHandler.Open(fileName);
This indirection is unnecessary. I would just call _paratextProjectFileHandler directly.
Fixes #318
Partially addresses sillsdev/serval#768
This change is