Fix: Remove Unused Mixin and Layout Callback from RenderLayoutBuilderPreserveBaseline Class #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilderPreserveBaseline class
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue (#110) introduced in Flutter version 3.29.0 and later, where the _RenderLayoutBuilderPreserveBaseline class was incorrectly using a non-existent mixin, RenderObjectWithLayoutCallbackMixin.
Changes Made
Removed the unused RenderObjectWithLayoutCallbackMixin from the _RenderLayoutBuilderPreserveBaseline class.
Simplified the class declaration to ensure compatibility with the current Flutter rendering system.
Eliminated the layout callback functionality that was not applicable, streamlining the layout process.