Merge in simplecov_json_formatter. #1130
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ℹ️ test failure seems unrelated, but I'm trying to fix it at #1131 |
simi
force-pushed
the
inline-simplecov-json-formatter
branch
from
ab8ff39 to
82644f4
Compare
|
ℹ️ rebased |
simi
force-pushed
the
inline-simplecov-json-formatter
branch
from
82644f4 to
9067fc6
Compare
|
@amatsuda WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I was working on configuring CI for
simplecov_json_formatterand I have realized, it seems probably better to merge it inside the main gem, since it is useless withoutSimpleCovat all (even having no dependency, but it is referencingSimpleCovin each file). And on the other side, there is no way to installSimpleCovwithoutsimplecov_json_formatter, since it is direct dependency.Happy to get proven wrong, but I don't see any reason to not merge it together, since
simplecov_json_formatteras separate gem felt a little out of radar even it is one of the top gems downloaded per month on RubyGems.org (currently with ~7M monthly downloads).I have ported JSON formatter 1:1, let the rubocop fix the style and added
verbose: trueadditional argument toformatmethod to keep original behaviour of putting message to stdout usingputs, but also to be able to keep it less verbose during testing.This gem was identified by RubyElders as one of the crucial for whole RubyGems.org ecosystem and it is crucial to get well maintained dependencies. I'm preparing blog post with more details on this effort.