Skip to content

Conversation

Richienb
Copy link
Collaborator

@Richienb Richienb commented Sep 8, 2025

Fixes #214
Closes #218

@Richienb
Copy link
Collaborator Author

Richienb commented Sep 8, 2025

// @sindresorhus

@Richienb Richienb marked this pull request as draft September 8, 2025 18:20
@Richienb Richienb marked this pull request as ready for review September 8, 2025 18:21
@Richienb Richienb marked this pull request as draft September 9, 2025 05:52
@sindresorhus
Copy link
Owner

I think {throwOnTimeout: false} was a mistake. It's surprising that it's just returns undefined, and having it as an option complicates types. What do you think about just making it the default behavior in the next major and dropping the option?

@Richienb
Copy link
Collaborator Author

Richienb commented Sep 24, 2025

@sindresorhus throwOnTimeout: true makes sense. But whether to remove it depends on what the use cases of throwOnTimeout are. My use case doesn't rely on timeouts so idk.

@sindresorhus
Copy link
Owner

e48716f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow not to copy/paste throwOnTimeout
2 participants