Skip to content

Fixes flutter 3.32 desktop crash #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025

Conversation

theniceboy
Copy link
Contributor

@theniceboy theniceboy commented May 26, 2025

Description

Flutter issue: flutter/flutter#169204

Related Issues

Fixes #2572
Fixes #2575

Type of Change

  • Feature: New functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Refactor: Code reorganization, no behavior change.
  • Breaking: Alters existing functionality and requires updates.
  • 🧪 Tests: New or modified tests
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Build/configuration changes.

@idispatch75
Copy link

FYI, this fixes the bug on Windows as well.

@idispatch75
Copy link

The bug reported in the flutter repo also mentions that didChangeDependencies() should be handled. It might apply here, but is not handled in this PR.

@ppamorim
Copy link

ppamorim commented Jun 4, 2025

@singerdmx Can we get this merged please?

@theachoem
Copy link
Contributor

@theniceboy rebase with the latest master may fix the test error. I'm looking for this too.

@rodolfogoulart
Copy link

@singerdmx Can we get this merged please?

Please 🙏

@FahimF
Copy link

FahimF commented Jul 1, 2025

@singerdmx Can we get this merged please?

Please 🙏

Another vote for merging this change in. Can't use Quill on macOS at all without this fix. Crashes as soon as you try to use the editor ... Tried on both Flutter 3.32.2 and 3.32.5 and the same results. Once I manually added the fix, no more crashes.

@sort72
Copy link

sort72 commented Jul 14, 2025

Quill is totally broken on Flutter 3.32.6 😢

@alinri
Copy link

alinri commented Jul 16, 2025

please merge.

@EchoEllet EchoEllet self-assigned this Jul 21, 2025
@EchoEllet
Copy link
Collaborator

I will merge it soon.

@EchoEllet EchoEllet merged commit 3cd4132 into singerdmx:master Jul 22, 2025
@EchoEllet
Copy link
Collaborator

The failing test added in #2616 now passes after merging this PR.

@EchoEllet EchoEllet changed the title Fixes flutter 3.32 macos crash Fixes flutter 3.32 desktop crash Jul 22, 2025
EchoEllet added a commit that referenced this pull request Jul 22, 2025
JeyDoubleU pushed a commit to Brainyoo/flutter-quill that referenced this pull request Aug 1, 2025
JeyDoubleU pushed a commit to Brainyoo/flutter-quill that referenced this pull request Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on macOS desktop app. NSInvalidArgumentException, reason: '-[NSNull longLongValue]: unrecognized selector sent to instance
10 participants