Skip to content

Conversation

@noprysk-ua
Copy link
Collaborator

@noprysk-ua noprysk-ua commented Jul 5, 2023

Recently, we introduced updateWindow for creating a workspace group. Updating all the dependencies with go get -u ./... to catch the change, including the Management API go client. To make sure that all is fine, run end-to-end tests locally. This is a blocker for #20.

@noprysk-ua noprysk-ua requested a review from jmonteiro13 July 5, 2023 16:38
@noprysk-ua noprysk-ua self-assigned this Jul 5, 2023
@noprysk-ua noprysk-ua temporarily deployed to test July 5, 2023 16:38 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #21 (eeaf522) into master (0c24d38) will decrease coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   73.56%   73.36%   -0.20%     
==========================================
  Files          18       18              
  Lines        1528     1528              
==========================================
- Hits         1124     1121       -3     
- Misses        335      337       +2     
- Partials       69       70       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@jmonteiro13 jmonteiro13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@noprysk-ua noprysk-ua merged commit 3ee4e67 into master Jul 5, 2023
@noprysk-ua noprysk-ua deleted the updating-dependencies branch July 5, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants