Migrate Notifications server to python #198 #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iteron-dev
requested changes
Jun 7, 2025
stopnoanime
force-pushed
the
notifications-python
branch
from
7712185 to
92aae1b
Compare
Contributor
Author
|
Unfortunately, I was able to reproduce socketify.py issue #141, which causes the server to segfault due to improper memory management within the library. As a result, I can no longer use socketify.py for the notifications server. The only viable alternative is the Python websockets library, though it is slower. I will rewritte the server to use the websocket liblary, however I'm uncertain if the performance will be satisfactory. |
Iteron-dev
reviewed
Jun 29, 2025
Iteron-dev
requested changes
Sep 27, 2025
twalen
previously approved these changes
Nov 19, 2025
Contributor
|
Please double check if the merge conflicts have been resolved correctly. |
Contributor
Author
|
Ok, will take a look at it today. |
Contributor
Author
|
All is good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated the server. Used socketify.py for high performance WebSockets. The server configuration variables and deployment remain the same. Additionally the server is now tested using the normal Django test suite.