Skip to content

Conversation

@bonnmh
Copy link

@bonnmh bonnmh commented Jan 30, 2024

Appstore is completely approved, I think it will help many people

@vozaldi
Copy link

vozaldi commented Feb 29, 2024

This patch works well

@skb1129
Copy link
Owner

skb1129 commented Mar 8, 2024

@bonnmh seeing as this is a custom implementation for the inbuilt function, can you please add some error handling?
Also, can you please move the React Native reject/resolve function calls to the function you've written?

@litinskii
Copy link

@skb1129

@bonnmh seeing as this is a custom implementation for the inbuilt function, can you please add some error handling?
Also, can you please move the React Native reject/resolve function calls to the function you've written?

i think it works as same as this part of code that was before (on error it do nothing without using resolve/reject for RN)

       [[UIApplication sharedApplication] setAlternateIconName:newIconName completionHandler:^(NSError * _Nullable error) {
            return;
        }];

@bibhuti9
Copy link

bibhuti9 commented Oct 3, 2024

@bonnmh Thanks for this feature.

@marcosbotene
Copy link

This is exactly what I need, will this PR request be closed? It seems to be working fine, but it's been open for almost a year.

@thanhnh98
Copy link

Excellent, works like a charm.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants