Skip to content

Conversation

@Borda
Copy link
Contributor

@Borda Borda commented May 28, 2025

Description

Switched from Black to Ruff for code formatting to simplify tooling. Updated .pre-commit-config.yaml and pyproject.toml to reflect the removal of Black and added Ruff-specific formatting configurations. This change ensures consistency and leverages Ruff's integrated formatting capabilities.

Checklist

  • Linked issues (if existing)
  • Amended changelog for large changes (and added myself there as contributor)
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Make sure to have fun coding!

Switched from Black to Ruff for code formatting to simplify tooling. Updated `.pre-commit-config.yaml` and `pyproject.toml` to reflect the removal of Black and added Ruff-specific formatting configurations. This change ensures consistency and leverages Ruff's integrated formatting capabilities.
@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@de1a4f1). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1853   +/-   ##
=======================================
  Coverage        ?   85.01%           
=======================================
  Files           ?       62           
  Lines           ?     6166           
  Branches        ?        0           
=======================================
  Hits            ?     5242           
  Misses          ?      924           
  Partials        ?        0           
Flag Coverage Δ
cpu 85.01% <100.00%> (?)
pytest 85.01% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fkiraly fkiraly changed the title Replace Black with Ruff formatting and update configuration [MNT] Replace Black with Ruff formatting and update configuration May 28, 2025
@fkiraly
Copy link
Collaborator

fkiraly commented May 28, 2025

@Borda, thanks a lot for the multiple packaging PR!

Since you are a lightning dev, we would be hugely thankful if you could look at our current design for pytorch-forecasting v2 where we are trying to:

  • abstract "loader-plus-network" objects to obtain a unified interface
  • use lightning feature better to enable scaling (not all pandas based)

In particular:

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label May 28, 2025
@Borda
Copy link
Contributor Author

Borda commented May 29, 2025

Since you are a lightning dev, we would be hugely thankful if you could look at our current design for pytorch-forecasting v2 where we are trying to:

  • abstract "loader-plus-network" objects to obtain a unified interface
  • use lightning feature better to enable scaling (not all pandas based)

Sure, I can have a look, just cannot guarantee how soon... :)

@Borda Borda requested a review from fkiraly May 29, 2025 10:45
@fkiraly
Copy link
Collaborator

fkiraly commented May 29, 2025

FYI @fnhirwa, review would be appreciated due to ruff

@fkiraly fkiraly merged commit 4384140 into sktime:main Jun 1, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Continuous integration, unit testing & package distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants