Skip to content

Conversation

markokajzer
Copy link
Contributor

update mongoid-scroll as discussed here

@dangerpr-bot
Copy link

dangerpr-bot commented Dec 2, 2024

1 Warning
⚠️ There're library changes, but not tests. That's OK as long as you're refactoring existing code.

Generated by 🚫 Danger

@dblock
Copy link
Collaborator

dblock commented Dec 3, 2024

I think we have a flaky test here:


  1) Teams oauth v2 oauth includes optional parameter
     Failure/Error: expect(SlackRubyBotServer::Service.instance).to receive(:create!).with(instance_of(Team), { state: 'property' })

       (#<SlackRubyBotServer::Service:0x000055ee85737d90 @callbacks={"creating"=>[], "created"=>[], "starting"=>[], "started"=>[]}, @intervals={}>).create!(an_instance_of(Team), {:state=>"property"})
           expected: 1 time with arguments: (an_instance_of(Team), {:state=>"property"})
           received: 0 times
     # ./spec/integration/teams_spec.rb:61:in `block (4 levels) in <top (required)>'
     # ./spec/database_adapters/mongoid/database_cleaner.rb:11:in `block (3 levels) in <top (required)>'
     # ./spec/database_adapters/mongoid/database_cleaner.rb:10:in `block (2 levels) in <top (required)>'

Care to take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants