Ensure error reporting when using buffered file writes #9102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quoting from the BufWriter docs: >It is critical to call flush before BufWriter<W> is dropped. Though >dropping will attempt to flush the contents of the buffer, any errors >that happen in the process of dropping will be ignored. Calling flush >ensures that the buffer is empty and thus dropping will not even >attempt file operations.
ubruhin
reviewed
Aug 8, 2025
| write!(&mut BufWriter::new(std::fs::File::create(&cpp_file_name)?), "{cpp_file}")?; | ||
| let mut cpp_writer = BufWriter::new(std::fs::File::create(&cpp_file_name)?); | ||
| write!(&mut cpp_writer, "{cpp_file}")?; | ||
| cpp_writer.flush()?; |
There was a problem hiding this comment.
Actually BufWriter could even be removed here I guess, as the whole file is written at once(?) Same applies to two other locations. EDIT: Hmm well maybe I'm wrong, I don't know exactly what's the type of cpp_file and how it gets written to the stream.
And btw, in my fork I still have the patch from #9092 included, so what I've actually tested is the combination of those two changes. Generally I'd still vote to implement the atomic file writes as long as there's no serious drawback (I didn't check the details about it).
ogoffart
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoting from the BufWriter docs: