Add length to spans and diagnostics #9703
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, diagnostics only indicated the first character of a warning/error.
While this is often sufficient, in many cases it leads to ambiguity as to what exactly causes the error.
This patch updates the
Span
type to add a length field and exposes this data to the diagnostic builder in the compiler and lsp.The patch is only large, as the syntax tests all needed to be updated. This was done via the automatic update mechanism.
The actual code changes are pretty straight-forward.
Also let me know whether the new syntax of
> <
for the syntax tests is acceptable.Compiler Diagnostics
Before:
After:
LSP (Screenshots from NVIM)
Before:

After:
