feat: Add queuing strategies for listener lists. #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I haven't checked the implementation details, but in any case, there is no possibility of accepting a PR without any testing. |
|
That seems like a good idea. I have added some now. |
notgull
approved these changes
Aug 3, 2025
Two strategies are available: - FIFO: The original round-robin queuing; listeners are inserted at the back. - LIFO: The new most-recent queuing; listeners are inserted at the front. LIFO queuing is beneficial for cache-efficiency with workloads that are tolerant of starvation. The same listener is repeatedly drawn from the list until the load dictates additional listeners be drawn from the list. These listeners expand outward as a "hot set" for optimal reuse of resources rather than continuously drawing from the coldest resources in a FIFO schedule. Signed-off-by: Jason Volk <[email protected]>
|
Looks like CI is failing now... |
|
Yea, do you need lifo implemented for slab?
…On Thu, Aug 7, 2025, 7:13 PM John Nunley ***@***.***> wrote:
*notgull* left a comment (smol-rs/event-listener#154)
<#154 (comment)>
Looks like CI is failing now...
—
Reply to this email directly, view it on GitHub
<#154 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDXHUTSM5JK3NMQ3DN6G4T3MQBUTAVCNFSM6AAAAACAHLZX2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNRWGM2DQNZXGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
No, just disable LIFO tests for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two strategies are available:
LIFO queuing is beneficial for cache-efficiency with workloads that are tolerant of starvation. The same listener is repeatedly drawn from the list until the load dictates additional listeners be drawn from the list. These listeners expand outward as a "hot set" for optimal reuse of resources rather than continuously drawing from the coldest resources in a FIFO schedule.
(Previously #149 but closed automatically when repository moved)