chore: update dependencies to latest versions and bump MSRV to 1.63 #104
Conversation
istankovic
changed the title
| run: cargo build --no-default-features --features alloc --target thumbv7m-none-eabi | ||
| - name: Test wasm | ||
| run: wasm-pack test --headless --chrome | ||
| run: RUSTFLAGS='--cfg getrandom_backend="wasm_js"' wasm-pack test --headless --chrome |
There was a problem hiding this comment.
Unfortunately, the fact that this flag is needed indicates that the getrandom upgrade needs to be considered a breaking change for our crate as well...
There was a problem hiding this comment.
Yes, true, I'm afraid there's no way around that.
|
@taiki-e would it be possible to merge this and release a new major version (3.0, since this is a breaking change) soon-ish? |
|
any updates on this? |
|
I think what we should do here is the same as what's proposed in ring. (i.e., vendoring the getrandom WASM code.) |
In particular, wyhash has been released which moves to rand 0.9, which brings quite a few of breaking changes. Luckily, we don't depend on it too much so the move is trivial.
istankovic
force-pushed
the
update-deps
branch
from
67d5b96 to
b2da446
Compare
Why? I'm not sure what value that would bring, but I do see the downside of adding more complexity and maintenance burden to fastrand. The discussion in ring seems to have to do with specifics in ring so I'm not sure what the relation to this crate is. |
3 participants
In particular, wyhash has been released which moves to rand 0.9, which brings quite a few of breaking changes. Luckily, we don't depend on it too much so the move is trivial. Also bump the MSRV to 1.63 to be in sync with getrandom and rand.