feat: Update 1.9.2 #369
Closed
feat: Update 1.9.2 #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cannon partitions
feat: add upstream version check workflow
docs: paring the further docs to specific cannon info
…ified [bump-release]
|
Caution Review failedThe pull request is closed. WalkthroughThis PR rebrands the Snakemake executor plugin from generic SLURM to Cannon-specific infrastructure at Harvard University. Changes include project metadata updates, new automation workflows for upstream release tracking and version management, enhanced resource validation logic, comprehensive documentation rewrite, and expanded test coverage with Cannon-specific profiles. Changes
Sequence Diagram(s)sequenceDiagram
participant Scheduler
participant Executor as Cannon Executor<br/>(__init__.py)
participant CANNON as CANNON<br/>(cannon.py)
participant Validation as Validation<br/>(validation.py)
participant Job
Scheduler->>Executor: Submit job with resources
rect rgb(220, 240, 250)
Note over Executor,CANNON: Resource Normalization
Executor->>CANNON: normalize_mem(job)
CANNON-->>Executor: mem_mb (normalized)
Executor->>CANNON: parse_num_gpus(job)
CANNON-->>Executor: gpu_count
end
rect rgb(240, 250, 220)
Note over Executor,CANNON: Partition Selection
Executor->>CANNON: get_cannon_partitions()
CANNON-->>Executor: partition_specs
alt GPU requested
Executor->>Executor: Select GPU partition
else Based on resources
Executor->>Executor: Select by mem/cpu/runtime
end
end
rect rgb(250, 220, 220)
Note over Executor,Validation: Validation
Executor->>Validation: validate_slurm_extra(job)
Validation-->>Executor: Valid or WorkflowError
Executor->>CANNON: check_resources(partition)
CANNON-->>Executor: OK or WorkflowError
end
Executor-->>Scheduler: Submit string with partition
sequenceDiagram
participant Upstream as Upstream<br/>snakemake-executor-plugin-slurm
participant Schedule as GitHub<br/>Scheduler
participant CheckJob as check-release<br/>Job
participant Notify as notify<br/>Job
participant Fork as Fork<br/>Repository
Schedule->>CheckJob: Trigger (daily / manual)
rect rgb(220, 240, 250)
Note over CheckJob,Upstream: Check Phase
CheckJob->>Upstream: Fetch latest release (API)
Upstream-->>CheckJob: Release version
CheckJob->>CheckJob: Compare with local version
CheckJob-->>Schedule: Exit 42 (sync-needed=true)<br/>or Exit 0
end
alt sync-needed = true
Schedule->>Notify: Run notify job
rect rgb(240, 250, 220)
Note over Notify,Fork: Notification Phase
Notify->>Fork: Check for existing sync PR
Fork-->>Notify: PR exists? or not found
alt No existing PR
Notify->>Fork: Create issue with sync instructions
else PR exists
Notify->>Notify: Skip (commented-out)
end
end
else sync-needed = false
Note over Schedule: No action needed
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes
Areas requiring extra attention:
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (29)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores