Generalize ISessionManager load/commit/reset to use Handler #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a type variable to SessionManger for Handler's base snaplet.
|
Hmmmm, this would be a backwards-incompatible change and this API has been stable for a very long time. I'm reluctant to make a breaking change for this. Perhaps you could do this in a separate library which will give you more freedom? |
|
The user facing change with this is to add one type parameter to If you ever require breaking changes do consider including this by then at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a type variable to SessionManger for Handler's base snaplet.
ISessionManager is rather awkward to use since it uses Snap monad and not Handlers. It precludes Session backends from using another DB or storage oriented snaplet.