Fix Python 3.13+ TypeError by decoding bytes URLs in storage client #2682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
Related issue #2676 |
sfc-gh-dszmolka
changed the title
sfc-gh-dszmolka
changed the title
Contributor
sfc-gh-fpawlowski
left a comment
sfc-gh-fpawlowski
left a comment
There was a problem hiding this comment.
Hi, thanks for the PR!
Left one comment, but overall seems good.
| logger.debug(f"retry #{self.retry_count[retry_id]}") | ||
| cur_timestamp = self.credentials.timestamp | ||
| url, rest_kwargs = get_request_args() | ||
| url = url.decode('utf-8') if isinstance(url, bytes) else url |
Contributor
There was a problem hiding this comment.
Could we move this check into the SessionManager.use_session? It should consistently accept both bytes and str as an input.
Author
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
No relevant GH issue.
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Fixes a TypeError that occurs on Python 3.13+ when performing PUT file operations. The storage client generates URLs as bytes, but the session manager (and vendored requests library) expects strings. Python 3.13's stricter type enforcement for string concatenation exposes this mismatch.
The fix decodes bytes URLs to UTF-8 strings before passing them to
use_session(), ensuring type consistency across the request pipeline while maintaining backward compatibility with string URLs.Note: This issue is specific to the LocalStack Snowflake emulator environment and is not reproducible with real Snowflake services. However, the fix improves type safety and ensures proper adherence to the
use_session()type contract (which expectsstr, notbytes).