Support jdk25

[CrazyHZM]

Summary by CodeRabbit

• Chores

  • CI pipeline now includes JDK 25 in the Maven build matrix.
  • Minor formatting adjustment in a workflow step with no effect on execution.

• Tests

  • Build matrix expanded to run against JDK 17, 21, and 25.

[coderabbitai]

Walkthrough

Updated GitHub Actions Maven workflow to add JDK 25 to the build matrix alongside 17 and 21. No changes to job steps or logic. Minor indentation/formatting adjustment in the Zookeeper install step.

Changes

Cohort / File(s)	Summary of changes
CI Workflow Matrix Update .github/workflows/maven.yml	Expanded matrix.jdk from [17, 21] to [17, 21, 25]; no functional step changes; minor indentation tweak in the Zookeeper install section.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I hop through builds with jaunty drive,
Now testing 17, 21—plus 25!
Zookeeper stands, its lines aligned,
The matrix grows, the checks refined.
Nibble-nibble, carrots thrive—
CI’s crisp, and code’s alive! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "Support jdk25" directly and concisely reflects the primary change in the changeset—adding JDK 25 to the CI Maven build matrix—so it accurately conveys the main intent and is clear for teammates scanning history. It avoids unnecessary detail and is focused on the key change described in the PR.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

.github/workflows/maven.yml (2)

19-19: JDK 25 in matrix: good. Also bump setup-java to v5 for smoother 25 support.

actions/setup-java v5 has the latest fixes and docs; Temurin 25 GA is rolling out now. Recommend upgrading the action and enabling check-latest for 25 to avoid stale caches. (github.com)

Apply:

-    - name: Set up JDK
-      uses: actions/setup-java@v4
+    - name: Set up JDK
+      uses: actions/setup-java@v5
       with:
         distribution: 'temurin'
-        java-version: ${{ matrix.jdk }}
+        java-version: ${{ matrix.jdk }}
+        check-latest: ${{ matrix.jdk == 25 }}
+        cache: 'maven'

---

27-33: Zookeeper 3.5.6 is EOL and likely brittle on JDK 25—upgrade to 3.8.x/3.9.x.

3.5.x is long EOL; current/stable are 3.9.x/3.8.x. Running the 2019-era 3.5.6 server under JDK 25 risks startup/runtime failures. Upgrade the test server to 3.9.3 (or 3.8.4). (zookeeper.apache.org)

Apply:

-    - name: Install Zookeeper
-      run: echo "Install Zookeeper 3.5.6"
-        && wget https://archive.apache.org/dist/zookeeper/zookeeper-3.5.6/apache-zookeeper-3.5.6-bin.tar.gz
-        && tar -zxf apache-zookeeper-3.5.6-bin.tar.gz
-        && mv apache-zookeeper-3.5.6-bin/conf/zoo_sample.cfg apache-zookeeper-3.5.6-bin/conf/zoo.cfg
-        && /bin/bash apache-zookeeper-3.5.6-bin/bin/zkServer.sh start
+    - name: Install ZooKeeper 3.9.3
+      run: |
+        echo "Install ZooKeeper 3.9.3"
+        wget https://archive.apache.org/dist/zookeeper/zookeeper-3.9.3/apache-zookeeper-3.9.3-bin.tar.gz
+        tar -zxf apache-zookeeper-3.9.3-bin.tar.gz
+        mv apache-zookeeper-3.9.3-bin/conf/zoo_sample.cfg apache-zookeeper-3.9.3-bin/conf/zoo.cfg
+        /bin/bash apache-zookeeper-3.9.3-bin/bin/zkServer.sh start

Optional: run ZK as a service container instead of tarball for faster, reproducible CI.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f4326d7 and 19a7c2b.

📒 Files selected for processing (1)

• .github/workflows/maven.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: sca