Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1367
There were two causes of Circular Import Error,
int_from_bytes
: The root cause is a circular dependency involvingstarknet_py.common
and otherstarknet_py
modules. The traceback states:cannot import name 'int_from_bytes' from partially initialized module 'starknet_py.common'
.HEX_PREFIX = "0x"
: This creates a circular dependency betweenstarknet_py.hash.address
andstarknet_py.hash.utils
when running the modulestarknet_py/tests/e2e/fixtures/clients.py
.CasmClassSchema
,Felt
...Introduced changes
Fixing this was moving
RevisionField
out of common to a separate module.