Move pinocchio crates into subdirectory #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem The Makefile model uses a slightly hacky way of distinguishing subdirectories, where anything before the first `-` is taken to be a directory name. This is a problem for `p-token` and `p-interface`, since the Makefile will look in `p/token` and `p/interface`. #### Summary of changes Move p-token into pinocchio/program and p-interface into pinocchio/interface. Update everything else as needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Makefile model uses a slightly hacky way of distinguishing subdirectories, where anything before the first
-is taken to be a directory name. This is a problem forp-tokenandp-interface, since the Makefile will look inp/tokenandp/interface.Summary of changes
Move p-token into pinocchio/program and p-interface into pinocchio/interface.
Update everything else as needed.