-
Notifications
You must be signed in to change notification settings - Fork 50
branch hints #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
branch hints #81
Conversation
Co-authored-by: Fernando Otero <[email protected]>
Co-authored-by: Fernando Otero <[email protected]>
Co-authored-by: Fernando Otero <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! Just some small nits. Have the CU savings been measured?
yea a bit over 10% less cus on transfer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thanks!
Edit: @febo I'll leave the final approval + merge to you though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Problem
It is possible to reduce CU consumption in the transfer instruction by using hints to the compiler, which allow it to optimize the code for the likely (hot) path.
Solution
This PR adds compiler hints to the transfer instruction.