-
Notifications
You must be signed in to change notification settings - Fork 285
fix(android): update library to support 16kb #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @naylinndev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on upgrading the underlying VLC library for the Android platform to its latest experimental version, which necessitated substantial refactoring of the existing codebase to align with the new API. It also includes updates to various development dependencies and SDK versions, ensuring the project remains current with the Flutter and Android ecosystems. The primary goal is to leverage the improvements and future capabilities offered by the updated VLC library.
Highlights
- Android VLC Library Update: The core VLC library for Android (
libvlc-all) has been significantly updated from version 3.6.0-eap14 to 4.0.0-eap21. This is a major version bump that required extensive code changes to maintain compatibility. - API Compatibility Adjustments: Due to the VLC 4.0 update, many media track-related methods (for audio, video, and SPU) have been removed or temporarily replaced with placeholders in
FlutterVlcPlayer.java. These methods will require reimplementation based on the new VLC 4.0 API. Additionally, video dimension retrieval now uses the texture view directly, and theseekTomethod now accepts alongtype. - Kotlin and Flutter SDK Updates: The Kotlin version used in the Android build has been updated to 2.1.0, and the project's Dart and Flutter SDK environment constraints have been raised to
>=3.8.0. - Pigeon Tooling Update: The
pigeondependency has been updated to a much newer major version (from^0.2.4to^26.0.1), and theconfigurePigeonfunction has been removed frommessages.dart, indicating changes in how Pigeon code generation is handled.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the native Android VLC library to a new major version (4.0 EAP), which is a significant change. This also required updating Kotlin and other dependencies. A major consequence is that many features related to audio, video, and subtitle track management have been temporarily disabled because of breaking API changes in libvlc. While this makes the plugin compile, it's a significant feature regression that needs to be addressed. Additionally, it appears that the auto-generated files from the pigeon package update are missing, which is a critical issue. The PR also includes several other improvements and cleanups.
flutter_vlc_player/android/src/main/java/software/solid/fluttervlcplayer/FlutterVlcPlayer.java
Show resolved
Hide resolved
flutter_vlc_player/android/src/main/java/software/solid/fluttervlcplayer/FlutterVlcPlayer.java
Show resolved
Hide resolved
|
Close as #539 merged. Let me know if you still miss anything. |
@illia-romanenko this pull request will fix the bug in #546 |
|
@illia-romanenko I made a pull request #547 . In this request, I fixed the audio track and subtitle track issues on Android after updating to VLC v4.0.0, and also fixed the issue where the example app couldn’t run. |
|
Thanks @alohadance98 - can you please submit another one - I'll merge. For some reason I can't reopen this one :( |
No description provided.