Fix #192: Add analyzer.plugins setup to documentation and test configuration #216
Conversation
milkyway-12
commented
Sep 8, 2025
milkyway-12
commented
- Added analyzer.plugins to test configuration example in README
- Updated lib/analysis_options_test.yaml to include analyzer.plugins to get correct configuration file
… (solid-software#212) * feat: lint default constructor only * feat: add named parameter * fix: rename test package * fix: add explicit null check * CR fixes * fix: make default constructor identifier field private
…nd test configuration
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @milkyway-12, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on improving the setup and functionality of static analysis tools. It resolves a documentation and configuration issue related to analyzer.plugins for custom linting, ensuring that the development environment is correctly configured. Additionally, it significantly enhances an existing lint rule, allowing developers to enforce more specific API usage patterns by banning default constructors and particular named parameters.
Highlights
- Documentation and Test Configuration Update: Updated the
README.mdto include theanalyzer.pluginssetup in the test configuration example and modifiedlib/analysis_options_test.yamlto correctly incorporateanalyzer.pluginsforcustom_lint, addressing issue #192. - Enhanced
avoid_using_apiLint Rule: Extended theavoid_using_apilint rule to allow banning of default constructors and specific named parameters within method invocations and instance creations, providing more granular control over API usage. - New Test Cases for API Usage Linting: Added comprehensive new test cases and a dedicated test suite (
lint_test/avoid_using_api/named_parameter_ban) to validate the newly implemented named parameter banning functionality for theavoid_using_apirule. - Code Formatting Configuration: Included a
formattersection inlib/analysis_options.yamlto explicitly preserve trailing commas, ensuring consistent code style.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly adds the analyzer.plugins configuration for custom_lint to the documentation and test analysis options, which is a necessary fix. It also introduces a valuable new feature to the avoid_using_api lint for banning specific named parameters, along with comprehensive tests. The implementation is solid. I have one suggestion to improve configuration consistency.
| - void_checks | ||
|
|
||
| formatter: | ||
| trailing_commas: preserve |
There was a problem hiding this comment.
The require_trailing_commas lint rule is enabled in this file, which is great for consistency. However, setting trailing_commas to preserve in the formatter configuration might lead to an inconsistent developer experience. preserve will not automatically add trailing commas, so developers might see lints from require_trailing_commas that dart format doesn't fix.
To align the formatter with the lint rule, consider changing preserve to always. This will ensure dart format automatically adds trailing commas, resolving the lint and providing a smoother workflow.
trailing_commas: always
|
Superceded by #217 |
3 participants
