UX improvements for renaming tabs #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

JorrenH wants to merge 1 commit into solidjs:master from JorrenH:feature/improvements-renaming-source-tabs

JorrenH commented Jan 15, 2023

I noticed some issues when renaming tabs in the playground. This PR implements/resolves the following:

Add 'Esc' as a button which stops editing tabname
Revert tabname when submitted as empty string
Store tabRefs by index, as names can change
Fix: focus sometimes not applied after doubleclick
Fix: cursor not active on doubleclick/focus (Firefox)


          Various improvements on renaming source tabs

48576c7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet