Skip to content

Conversation

@thomasbuilds
Copy link
Contributor

@thomasbuilds thomasbuilds commented Sep 12, 2025

Moved the README.md file from the root directory to packages/start and created a symlink pointing back to the root to ensure proper documentation display on both GitHub and npm (currently, the README on npm is empty).

Also improved:

  • Banner alignment
  • Added a clientOnly link in the CSR description, noting that CSR can be page- or component-scoped.

@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2025

⚠️ No Changeset found

Latest commit: dec7eeb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Sep 12, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit dec7eeb
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/68d904ce8a62150009f91f77
😎 Deploy Preview https://deploy-preview-1971--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atilafassina
Copy link
Member

Hey, Thomas

thanks a lot for this effort - but we had to re-write CONTRIBUTIONS.md and adjust the README.md files as well.

So, closing this in favor of #1977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants