Skip to content

Add a redirect from /legal/DPA to /legal/dpa #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a redirect from /legal/DPA to /legal/dpa #969

wants to merge 1 commit into from

Conversation

@ab
Copy link
Contributor

@ab ab commented Nov 17, 2025 •
edited by cursor bot
Loading

Description of the change

There are existing links in legal documents that point to the old uppercase URL at https://docs.spacelift.io/legal/DPA. These links were broken by removing the duplicate DPA.md in PR #949.

Add a redirect to lowercase dpa so that it continues to work.

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 🙇

Note

Adds a redirect in mkdocs to map legal/DPA.md to legal/dpa.md for legacy links.

  • Docs config (mkdocs.yaml):
    • Redirects: Add mapping legal/DPA.md → legal/dpa.md under plugins.redirects.redirect_maps.

Written by Cursor Bugbot for commit 402fe6a. This will update automatically on new commits. Configure here.

@ab
Add a redirect from /legal/DPA to /legal/dpa
402fe6a 
There are existing links in legal documents that point to the old
uppercase URL. These links were broken by removing the duplicate DPA.md
in PR spacelift-io#949.

Add a redirect so that it continues to work.
@ab
Copy link
Contributor Author

ab commented Nov 17, 2025

I tested this locally and it seems to work. But the pages are served at /legal/dpa.html / /legal/DPA.html locally, whereas they are served at /legal/dpa without the file extension on the prod docs, so I couldn't test exactly the same URL as I expected to see.

$ curl -i http://localhost:8000/legal/DPA.html
HTTP/1.0 200 OK
Date: Mon, 17 Nov 2025 15:28:07 GMT
Server: WSGIServer/0.2 CPython/3.13.8
Content-Type: text/html
Content-Length: 414


<!doctype html>
<html lang="en">
<head>
    <meta charset="utf-8">
    <title>Redirecting...</title>
    <link rel="canonical" href="dpa.html">
    <script>var anchor=window.location.hash.substr(1);location.href="dpa.html"+(anchor?"#"+anchor:"")</script>
    <meta http-equiv="refresh" content="0; url=dpa.html">
</head>
<body>
You're being redirected to a <a href="dpa.html">new destination</a>.
</body>
</html>

@ab ab marked this pull request as ready for review November 17, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ab