Skip to content

fix for local anchors #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2025
Merged

Conversation

randomlogin
Copy link
Member

It's impossible to run fabric with local root anchors file:

$ fabric --local-anchors rootanchors.json
Must specify exactly one of local, remote, or static anchors.

It always sets remote anchors even if they were not provided. But later there is a check whether only 1 options was used:

  private constructor(private options: UpdateOptions) {
    const usingLocal = !!options.localPath;
    const usingRemote = !!options.remoteUrls;
    const usingStaticAnchors = !!options.staticAnchors;

    if ([usingLocal, usingRemote, usingStaticAnchors].filter(Boolean).length != 1) {
      throw new Error('Must specify exactly one of local, remote, or static anchors.');
    }

@randomlogin randomlogin changed the title fix of for local anchors file fix of local anchors file Jun 27, 2025
@randomlogin randomlogin changed the title fix of local anchors file fix for local anchors Jun 27, 2025
Copy link
Member

@buffrr buffrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@buffrr buffrr merged commit 7cf9872 into spacesprotocol:main Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants