Force long output text to scroll #831
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, long cell output does not scroll. This has been adressed in issues #754 #417 and #372.
These cells are already correctly configured to scroll upon overflow from various parent classes.
The reason these outputs don't scroll vertically is simply because there is no limit on how much vertical space they are allowed to take, so they never overflow.
This PR simply implements a maximum height of
600px
for allnboutput container
classes, but only for those that contain text. I chose600px
rather arbitrarily, feel free to change to something more dynamic (don't forget to update docs as well then).Checking if they contain text is done by checking if they have a child with
pre
. I'm not very accustomed to CSS, so I don't know if this is a good way to check.I also added an example for this in the docs.