Feature/add tts #51
Open
Feature/add tts #51
+2,480
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TudorCRL
reviewed
Oct 22, 2025
| @@ -0,0 +1,274 @@ | |||
| # Speechmatics Batch API Client | |||
There was a problem hiding this comment.
This README needs rewriting to reflect the TTS client rather than batch
| from speechmatics.tts import AsyncClient | ||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_async_http(): |
There was a problem hiding this comment.
This is great! Love to have tests in place. One thing to raise is that the tests will always fail in the pipeline if we don't have an API key (e.g. it's not configured or we're on a fork). We probably want something which first checks we have an API key and then runs the test if we do. We can talk about that offline if you want
There was a problem hiding this comment.
In my voice sdk tests, I add in the following at the top (see tests/voice/test_02_transcriber.py):
# Skip for CI testing
pytestmark = pytest.mark.skipif(os.getenv("CI") == "true", reason="Skipping transcriber tests in CI")
Co-authored-by: Tudor Evans <[email protected]>
Co-authored-by: Tudor Evans <[email protected]>
Co-authored-by: Tudor Evans <[email protected]>
Co-authored-by: Tudor Evans <[email protected]>
Co-authored-by: Tudor Evans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TTS async client