Remove mypy overrides for tests.test_quickstart #13749
Merged
+14
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamtheturtle
force-pushed
the
next-typing
branch
from
93ca46a to
33fed87
Compare
adamtheturtle
commented
Jul 25, 2025
tests/test_quickstart.py
Outdated
| def mock_input( | ||
| answers: dict[str, str], needanswer: bool = False | ||
| ) -> Callable[[str], str]: | ||
| class _MockTermInput(Protocol): |
There was a problem hiding this comment.
An alternative to much of the work here is to make term_input take only keyword arguments:
def term_input(prompt: str, /) -> str:
There was a problem hiding this comment.
Do you mean positional-only? That would be fine.
There was a problem hiding this comment.
Yes sorry. Ok I'll do that and this PR will be simpler
There was a problem hiding this comment.
I have made this change
adamtheturtle
force-pushed
the
next-typing
branch
from
33fed87 to
2645d29
Compare
|
@adamtheturtle a note for the future; please can you avoid force-pushing your branches? GH limitations make it harder to review (#13714 (comment)). A |
AA-Turner
approved these changes
Jul 26, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.