feat: add comment in .conf files #112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemrys
reviewed
Jul 29, 2025
| self.assertEqual(expected_item_dict, parser.item_dict()) | ||
|
|
||
| def test_item_dict_when_preserve_comment_True(self): |
There was a problem hiding this comment.
Can we have a test which has conf, then item_dict and then dump to a string? I would expect to see the same as in the original conf.
artemrys
reviewed
Jul 30, 2025
| EVAL-deprecated_field = "old_value" | ||
| def test_item_dict_when_preserve_comment_False(self): | ||
| parser = conf_parser.TABConfigParser() | ||
| parser.read(CONF_PATH) |
There was a problem hiding this comment.
nit: you could inline the conf and parametrize the test to stay consistent with other tests but totally up to you
There was a problem hiding this comment.
I did try it earlier with @pytest.mark.parametrize but for some reason test were failing.
|
The final decision is to revert the PR because the feature is currently not needed and requires further enhancements. These improvements will be addressed in the UCC 6 major release, so this PR is no longer necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new variable,
preserve_comments, to control whether comments are included when returning dict. When preserve_comments is set to True, comments will be included and vice versa