Git app install changes #156
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved cluster evaluation out of the install_apps loop - Moved bundle push out of the install_apps loop - Created task files for bundle application - Created single file to call for bundle application with inferences
|
Im interested in this PR. Maybe also add support for local apps at the same time? PR #81 |
Contributor
Author
|
Sorry this closed - I had to re-fork the repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Git apps install is nice, but it's SLOW. If you use this on a system that is even moderately loaded, you get huge performance hits. This PR is to help optimize the
install_appsloop and to take out unnecessary components. The changes at a glance are:install_appsloopinstall_appsloopconfigure_appsThis really improves the loop functionality, as not only are bundle evals not being done inline, but this ports the bundle evals outside the loop to be reused by other plays or tasks. Having them as solely handlers is not good enough.