Feat/autodiscovery #1234
Open
Feat/autodiscovery #1234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add discovery for docker * chore: update replica count * chore: update replica count
* feat: Added deployment for k8s * Changed the queue name from autodiscover to discovery
* feat: initial commit with application code * Added logic for mounting the final output csv file * feat: addressed review comments * chore: removed the init container and handled the volume mounting without it * feat: added support for scaling discovery worker pods * chore: Updated port validation * feat: Added support for snmp version 3 in docker and handled volume mounting * fix: Corrected the discovery paths in environment variable and removed unnecessary variables
#1224) * feat: added configurable parameter for SNMP request's retry and timeout. Handled tasktimeout configurable parameter for discovery * fix: handled race condition when discovery tasks tries to update the output csv file concurrently * chore: Executed make render command with the latest yaml changes * chore: removed --min-rate as nmap dynamically detects a suitable rate at which packets should be sent * chore: incorporated the pr review changes
* docs: Added doc changes for discovery feature * docs: spell checks * chore: resolved pr review comments
…1231) * chore: Added architecture diagram which includes discovery feature * chore: updated background of Discovery
…r-snmp into feat/autodiscovery
…-connect-for-snmp into feat/autodiscovery
cwadhwani-splunk
requested review from
ajasnosz and
omrozowicz-splunk
and removed request for
omrozowicz-splunk
* chore: used csv package instead of pandas * chore: quick fix * chore: pre-commit changes * chore: resolved review comments
* feat: added dashboards for tracking discovery tasks * chore: added documentation for the dashboard update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added SNMP-enabled device discovery feature
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested this feature manually by deploying multiple snmp enabled devices in network.
Checklist