Issue #1227: Fix module testing not working due to call to JUnit internal API #2187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasTu
approved these changes
Oct 18, 2025
AndreasTu
requested changes
Oct 18, 2025
| public class ClassUtil { | ||
| public static @NotNull String nullSafeToString(@Nullable Class<?> clazz) { | ||
| if (clazz != null) | ||
| return clazz.toString(); |
There was a problem hiding this comment.
The org.junit.platform.commons.util.ClassUtils uses Class.getName() instead of Class.toString().
Please change that, to ensure compatibility with existing code.
| import java.util.Arrays; | ||
| import static java.util.stream.Collectors.joining; | ||
|
|
||
| public class ClassUtil { |
There was a problem hiding this comment.
Please add a line in
docs\release_notes.adoc
under
== 2.4 (tbd)
=== Misc
* Fix module testing not working due to call to JUnit internal API spockPull:2187[]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've replaced a use of the internal JUnit class
org.junit.platform.commons.util.ClassUtilswith a new customorg.spockframework.util.ClassUtilclass. This fixes issue #1227 (tested with my project).